[llvm][NFC] Update LocalVarDef::CVRegister to fix size MS ABI #140214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-debuginfo Author: Oliver Hunt (ojhunt) ChangesLocalVarDef::CVRegister being a uint16_t is not enough for the fields to be packed with the MS ABI. This makes the field a 16 bit a uint32_t Full diff: https://github.com/llvm/llvm-project/pull/140214.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
index be6eb4c8998bd..d13b315135ad9 100644
--- a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
+++ b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
@@ -70,7 +70,7 @@ class LLVM_LIBRARY_VISIBILITY CodeViewDebug : public DebugHandlerBase {
/// Register containing the data or the register base of the memory
/// location containing the data.
- uint16_t CVRegister;
+ uint32_t CVRegister : 16;
uint64_t static toOpaqueValue(const LocalVarDef DR) {
uint64_t Val = 0;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalVarDef::CVRegister being a uint16_t is not enough for the fields to be packed with the MS ABI.
This makes the field a 16 bit a uint32_t